test-verify installs full venv even after it knows there is no work to do
Categories
(Testing :: General, enhancement, P1)
Tracking
(firefox72 fixed)
| Tracking | Status | |
|---|---|---|
| firefox72 | --- | fixed |
People
(Reporter: gbrown, Assigned: gbrown)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
A minor optimization....
test-verify tasks (TV, TVg, TVw) are sometimes started even when there is no work to do. For instance, if only non-gpu tests are modified on a push, TVg will still be scheduled (the decision task doesn't have enough information to distinguish TV/TVg), but will run no tests. The test-verify tasks identify which tests need to run fairly quickly - often in less than 1 minute - but currently they continue to run through all of the mozharness setup steps, including, notably, setting up the virtual env.
test-verify tasks with no tests to run could bail out faster, saving a minute or two per run.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
This minor optimization is easily implemented: If there are no tests to verify, call fatal(0).
However, I encountered a minor obstacle: If the task exits before creating the upload directory,
the task fails, regardless of exit value; the remaining changes overcome this by creating the
upload directory earlier.
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
Description
•